db: Cleanup parent/child relations in matching models #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
force-pushed
the
working-parent-child-relations
branch
from
17ddf17
to
de067be
Compare
The previous relations didn't work as expected. Now, filtering with `child.host.name` or `parent.service.name` works fine.
nilmerg
force-pushed
the
working-parent-child-relations
branch
from
9e386bd
to
b5a4caa
Compare
There was a problem hiding this comment.
Test:
I have used the example configuration but reduced the number of objects (loop range).
Tested this PR with the filter icingadb/hosts?parent.host.name=big-switch-server-0.
Expected behavior:
No result, as there is no child existing with this host as parent.
Actual behavior:
One host big-switch-server-0 (self) as result. // There are services that have this host as a parent
The sql query:
(icingadb/hosts?parent.host.name=big-switch-server-0&format=sql)
...
WHERE host.id IN ((SELECT sub_host_to_from_host.id AS sub_host_to_from_host_id
FROM host sub_host
INNER JOIN dependency_node sub_host_dependency_node # here we have 1:n (host : dependency_node) relation
ON sub_host_dependency_node.host_id = sub_host.id
INNER JOIN dependency_edge sub_host_to
ON sub_host_to.to_node_id = sub_host_dependency_node.id
INNER JOIN dependency_node sub_host_to_from
ON sub_host_to_from.id = sub_host_to.from_node_id
LEFT JOIN host sub_host_to_from_host ON sub_host_to_from_host.id = sub_host_to_from.host_id
WHERE sub_host.name = 'big-switch-server-0'))
ORDER BY host.display_name
LIMIT 25;The column dependency_node.host_id is not unique and there are several identical entries in case services exist for this host. This leads to a ‘1:n’ relationship, which leads to false positive results.
Adding a service filter in the case of a host solves this problem.
sukhwinder33445
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous relations didn't work as expected.
Now, filtering with
child.host.nameorparent.service.nameworks fine.